smiklosovic commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1158237917
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1021,9 +1041,9 @@ private static String storagedirFor(String type)
private static String storagedir(String errMsgType)
{
- String storagedir = System.getProperty(Config.PROPERTY_PREFIX +
"storagedir", null);
+ String storagedir = STORAGE_DIR.getString();
if (storagedir == null)
- throw new ConfigurationException(errMsgType + " is missing and
-Dcassandra.storagedir is not set", false);
+ throw new ConfigurationException(errMsgType + " is missing and -D"
+ STORAGE_DIR.getKey() + " is not set", false);
Review Comment:
matter of taste, I dont have anything against _not_ specifying `-D` but we
should be consistent in whatever we choose. Not only here. All similar cases
where `-D` is added should be revisited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
