smiklosovic commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1153087203
##########
src/java/org/apache/cassandra/db/compaction/TimeWindowCompactionStrategyOptions.java:
##########
@@ -45,7 +46,7 @@
public static final String EXPIRED_SSTABLE_CHECK_FREQUENCY_SECONDS_KEY =
"expired_sstable_check_frequency_seconds";
public static final String UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_KEY =
"unsafe_aggressive_sstable_expiration";
- static final String UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_PROPERTY =
Config.PROPERTY_PREFIX + "allow_unsafe_aggressive_sstable_expiration";
+ static final boolean UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION_ENABLED =
ALLOW_UNSAFE_AGGRESSIVE_SSTABLE_EXPIRATION.getBoolean();
Review Comment:
Should not this go away? If you check the logic, that property is resolved
in runtime. What if we have dynamic changing of properties as we plan it? Then
we could not tweak this in runtime because it is set in stone, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
