dcapwell commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1162137504
##########
accord-core/src/main/java/accord/api/MessageSink.java:
##########
@@ -27,6 +28,6 @@
public interface MessageSink
{
void send(Id to, Request request);
- void send(Id to, Request request, Callback callback);
+ void send(Id to, Request request, CommandStore commandStore, Callback
callback);
Review Comment:
> So why not put the storage in Callback and make it an abstract base class.
This has an annoying impact to all code, as all code must now figure out
what store to run in rather than the small set that need to do this today. ATM
this is inferred in the majority of cases, so only a few cases need to think
about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
