dcapwell commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1176908488
##########
accord-core/src/main/java/accord/coordinate/Coordinate.java:
##########
@@ -72,7 +72,8 @@ private void start()
{
// TODO (desired, efficiency): consider sending only to electorate of
most recent topology (as only these PreAccept votes matter)
// note that we must send to all replicas of old topology, as
electorate may not be reachable
- node.send(tracker.nodes(), to -> new PreAccept(to,
tracker.topologies(), txnId, txn, route), this);
+ node.send(tracker.nodes(), to -> new PreAccept(to,
tracker.topologies(), txnId, txn, route),
+ node.commandStores().from(route), this);
Review Comment:
> also, should probably use home key by default to pick?
Pushed the change and removed one of the `from` methods as it was only used
by `Routes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
