dcapwell commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1163301593
##########
accord-core/src/main/java/accord/utils/async/AsyncChain.java:
##########
@@ -63,6 +63,13 @@ default AsyncChain<Void> accept(Consumer<? super V> action,
Executor executor)
}, executor);
}
+ default AsyncChain<V> withExecutor(Executor e)
Review Comment:
the common case is that your "chain" is just a sequence of callbacks on the
same thread, so we only ever need to define the executor at the start of the
chain rather than maintain it for each step in the chain like you do with
`ListenableFuture`, but you are right, not thinking about executors can be a
problem and was one of the biggest issues getting this patch to work... but if
people just put `direct` you kinda shot yourself in the foot just to compile =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
