Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1164450398
##########
src/java/org/apache/cassandra/gms/Gossiper.java:
##########
@@ -106,9 +108,12 @@ public class Gossiper implements
IFailureDetectionEventListener, GossiperMBean
{
public static final String MBEAN_NAME =
"org.apache.cassandra.net:type=Gossiper";
+ /** @deprecated Use
CassandraRelevantProperties.GOSSIP_DISABLE_THREAD_VALIDATION instead. */
+ @Deprecated
public static class Props
Review Comment:
Fixed.
##########
src/java/org/apache/cassandra/schema/CompactionParams.java:
##########
@@ -77,7 +78,7 @@ public static Optional<TombstoneOption> forName(String name)
public static final boolean DEFAULT_ENABLED = true;
public static final TombstoneOption DEFAULT_PROVIDE_OVERLAPPING_TOMBSTONES
=
-
TombstoneOption.valueOf(System.getProperty("default.provide.overlapping.tombstones",
TombstoneOption.NONE.toString()).toUpperCase());
+
TombstoneOption.valueOf(CassandraRelevantProperties.DEFAULT_PROVIDE_OVERLAPPING_TOMBSTONES.getString(TombstoneOption.NONE.toString()).toUpperCase());
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]