Mmuzaf commented on code in PR #2046: URL: https://github.com/apache/cassandra/pull/2046#discussion_r1158394287
########## src/java/org/apache/cassandra/config/CassandraRelevantProperties.java: ########## Review Comment: All newly added properties are sorted alphabetically, should we sort them all? I'm not sure it's possible to do this with a single click, as some of the javadoc comments are used above the enum instances. But if we want to keep them sorted, we should also add a static initializer (or test) to check the order, as you mentioned the same below for duplicates. So, should we? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
