Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1164495609
##########
test/unit/org/apache/cassandra/LogbackStatusListener.java:
##########
@@ -475,9 +479,9 @@ public synchronized void onStart(LoggerContext
loggerContext)
Logger stdoutLogger = LoggerFactory.getLogger("stdout");
Logger stderrLogger = LoggerFactory.getLogger("stderr");
- replacementOut = wrapLogger(stdoutLogger, originalOut,
"sun.stdout.encoding", false);
Review Comment:
I think it would be better to keep these constants matching their names as
we already have a lot of constants with `JAVA_` prefix. So
`SUN_STDOUT_ENCODING` looks better according to everything we already have,
WDYT? I have renamed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
