Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1164736520
##########
test/unit/org/apache/cassandra/config/YamlConfigurationLoaderTest.java:
##########
@@ -92,13 +97,12 @@ public void withSystemProperties()
// It is possible that we define a common string representation for
these types so they can be written to; this
// is an issue that SettingsTable may need to worry about.
try (WithProperties ignore = new
WithProperties(CONFIG_ALLOW_SYSTEM_PROPERTIES.getKey(), "true",
- SYSTEM_PROPERTY_PREFIX
+ "storage_port", "123",
- SYSTEM_PROPERTY_PREFIX
+ "commitlog_sync", "batch",
- SYSTEM_PROPERTY_PREFIX
+ "seed_provider.class_name", "org.apache.cassandra.locator.SimpleSeedProvider",
-// PROPERTY_PREFIX +
"client_encryption_options.cipher_suites", "[\"FakeCipher\"]",
- SYSTEM_PROPERTY_PREFIX
+ "client_encryption_options.optional", "false",
- SYSTEM_PROPERTY_PREFIX
+ "client_encryption_options.enabled", "true",
- SYSTEM_PROPERTY_PREFIX
+ "doesnotexist", "true"
+
CASSANDRA_SETTINGS_STORAGE_PORT.getKey(), "123",
Review Comment:
Agree. This was my misunderstanding of the usage of `cassandra.settings`, so
I have reverted the changes back to the trunk state. I don't think we should
fix the test in the way you suggested in this PR (however I agree that in
current state the test looks fragile) as we do not even need to change
`YamlConfigurationLoaderTest` in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
