Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1164745985
##########
test/simulator/asm/org/apache/cassandra/simulator/asm/MethodLogger.java:
##########
@@ -37,6 +37,8 @@
import static org.apache.cassandra.simulator.asm.MethodLogger.Level.NONE;
import static org.apache.cassandra.simulator.asm.MethodLogger.Level.valueOf;
+// checkstyle: suppress below 'blockSystemPropertyUsage'
Review Comment:
This is because `org.apache.cassandra.simulator.asm` has its own classpath
for compilation, so there is no access to the `org.apache.cassandra.config`
package, but the checkstyle runs over all the source code. The test system
properties from the `MethodLogger` do not seem to be relevant to Cassandra
itself.
Here is how the `asm` classes are compiled:
```
<javac compiler="modern" debug="true" debuglevel="${debuglevel}"
source="${ant.java.version}" target="${ant.java.version}"
encoding="utf-8" destdir="${simulator-asm.build.classes}"
includeantruntime="true">
<src path="${simulator-asm.build.src}" />
<classpath>
<fileset dir="${test.lib}">
<include name="**/asm-*${asm.version}.jar" />
</fileset>
<fileset dir="${build.lib}">
<include name="**/asm-*${asm.version}.jar" />
</fileset>
</classpath>
</javac>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
