adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1171610691
##########
conf/jvm-server.options:
##########
@@ -181,8 +181,8 @@
###################################
# Defines how to handle INSERT requests with TTL exceeding the maximum
supported expiration date:
-# * REJECT: this is the default policy and will reject any requests with
expiration date timestamp after 2038-01-19T03:14:06+00:00.
-# * CAP: any insert with TTL expiring after 2038-01-19T03:14:06+00:00 will
expire on 2038-01-19T03:14:06+00:00 and the client will receive a warning.
+# * REJECT: this is the default policy and will reject any requests with
expiration date timestamp after 2106-02-07T06:28:13+00:00 or
2038-01-19T03:14:06+00:00 depending on compatibility mode
+# * CAP: any insert with TTL expiring after 2106-02-07T06:28:13+00:00 or
2038-01-19T03:14:06+00:00 will expire on 2106-02-07T06:28:13+00:00 or
2038-01-19T03:14:06+00:00 and the client will receive a warning.
Review Comment:
We could give some additional details about the two possible max dates, and
split the long lines:
```suggestion
# * REJECT: this is the default policy and will reject any requests with
expiration date timestamp after
# 2106-02-07T06:28:13+00:00 or 2038-01-19T03:14:06+00:00 depending on
compatibility mode (<="nc" sstable formats)
# * CAP: any insert with TTL expiring after 2106-02-07T06:28:13+00:00 or
2038-01-19T03:14:06+00:00, depending on
# compatibility mode (<="nc" sstable formats), will expire on
2106-02-07T06:28:13+00:00 or 2038-01-19T03:14:06+00:00
and the client will receive a warning.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
