adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1184917714
##########
src/java/org/apache/cassandra/db/commitlog/CommitLogDescriptor.java:
##########
@@ -62,13 +64,14 @@
// We don't support anything pre-3.0
public static final int VERSION_30 = 6;
public static final int VERSION_40 = 7;
+ public static final int VERSION_50 = 8;
/**
* Increment this number if there is a changes in the commit log disc
layout or MessagingVersion changes.
* Note: make sure to handle {@link #getMessagingVersion()}
*/
@VisibleForTesting
- public static final int current_version = VERSION_40;
+ public static final int current_version =
BigFormat.ttlMode.equals(TTL_MODE.LEGACY_TTL_2038) ? VERSION_40 : VERSION_50;
Review Comment:
```suggestion
public static final int current_version = BigFormat.ttlMode ==
TTL_MODE.LEGACY_TTL_2038 ? VERSION_40 : VERSION_50;
```
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -360,6 +361,8 @@
FLUSH_LOCAL_SCHEMA_CHANGES("cassandra.test.flush_local_schema_changes",
"true"),
TOMBSTONE_HISTOGRAM_TTL_ROUND_SECONDS("cassandra.streaminghistogram.roundseconds",
"60"),
+
+ USE_OA_SSTABLE_FORMAT("cassandra.use_oa_sstable_format",
BigFormat.TTL_MODE.LEGACY_TTL_2038.toString())
Review Comment:
I'd add some brief documentation here, including the purpose of each value
and how this is meant to be used.
##########
src/java/org/apache/cassandra/io/sstable/format/big/BigFormat.java:
##########
@@ -69,6 +71,10 @@ public class BigFormat extends
AbstractSSTableFormat<BigTableReader, BigTableWri
{
private final static Logger logger =
LoggerFactory.getLogger(BigFormat.class);
+ // Feature flag env variable to use extended TTL up to 2106 with the new
oa sstable format. See c14227
Review Comment:
I'd add a brief description of the purpose of each enum value.
##########
src/java/org/apache/cassandra/hints/HintsDescriptor.java:
##########
@@ -66,7 +68,8 @@
static final int VERSION_30 = 1;
static final int VERSION_40 = 2;
- static final int CURRENT_VERSION = VERSION_40;
+ static final int VERSION_50 = 3;
+ static final int CURRENT_VERSION =
BigFormat.ttlMode.equals(TTL_MODE.LEGACY_TTL_2038) ? VERSION_40 : VERSION_50;
Review Comment:
```suggestion
static final int CURRENT_VERSION = BigFormat.ttlMode ==
TTL_MODE.LEGACY_TTL_2038 ? VERSION_40 : VERSION_50;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
