bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1173447223
##########
src/java/org/apache/cassandra/io/sstable/format/big/BigFormat.java:
##########
@@ -411,7 +415,8 @@ static class BigVersion extends Version
hasCommitLogIntervals = version.compareTo("mc") >= 0;
hasAccurateMinMax = version.matches("(m[d-z])|(n[a-z])"); //
deprecated in 'nc' and to be removed in 'oa'
hasLegacyMinMax = version.matches("(m[a-z])|(n[a-z])"); //
deprecated in 'nc' and to be removed in 'oa'
- hasOriginatingHostId = version.matches("(m[e-z])") ||
version.compareTo("nb") >= 0;
+ // When adding a new version you might need to add it here
+ hasOriginatingHostId = version.matches("(m[e-z])|(o[a-z])") ||
version.compareTo("nb") >= 0;
Review Comment:
I'm really surprised about this one as I distinctly remember adding that fix
after a hellish debugging session. That's why I added the comment `// When
adding a new version you might need to add it here`.
I guess in some previous version of the code sthg made it not work but it
works as expected now. Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
