bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1185717994
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -360,6 +361,8 @@
FLUSH_LOCAL_SCHEMA_CHANGES("cassandra.test.flush_local_schema_changes",
"true"),
TOMBSTONE_HISTOGRAM_TTL_ROUND_SECONDS("cassandra.streaminghistogram.roundseconds",
"60"),
+
+ USE_OA_SSTABLE_FORMAT("cassandra.use_oa_sstable_format",
BigFormat.TTL_MODE.LEGACY_TTL_2038.toString())
Review Comment:
Whatever the new downgradability thing comes it will use whatever mechanics
it decides. I still think it won't be a boolean mainly bc during mixed clusters
you need a way to dynamically check the cluster status. That check could be in
the hot path, such as it's here, so you need a 3rd value to signal the cluster
is fully migrated and we can spare that check.
I can add the comment. But I wouldn't mark it as deprecated until that
ticket is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
