bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1184559832
##########
src/java/org/apache/cassandra/io/sstable/format/big/BigFormat.java:
##########
@@ -69,11 +73,19 @@ public class BigFormat extends
AbstractSSTableFormat<BigTableReader, BigTableWri
{
private final static Logger logger =
LoggerFactory.getLogger(BigFormat.class);
+ // Feature flag env variable to use extended TTL up to 2106 with the new
oa sstable format. See c14227
+ public static enum TTL_MODE {LEGACY_TTL_2038, COMPATIBILITY,
EXTENDED_TTL_2106};
+ @VisibleForTesting
+ public static final String USE_OA_SSTABLE_FORMAT =
"cassandra.use_oa_sstable_format";
Review Comment:
I've had these same exact thoughts. But a silent sstable format change
doesn't sound pretty to me either. We need to come up with a name/values that
link the TTL and sstable concepts imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
