dcapwell commented on code in PR #46:
URL: https://github.com/apache/cassandra-accord/pull/46#discussion_r1206076157
##########
accord-core/src/main/java/accord/local/SafeCommandStore.java:
##########
@@ -155,6 +156,7 @@ <T> T mapReduce(Seekables<?, ?> keys, Ranges slice,
NodeTimeService time();
CommandStores.RangesForEpoch ranges();
Timestamp maxConflict(Seekables<?, ?> keys, Ranges slice);
+ void registerHistoricalTransactions(Deps deps);
Review Comment:
sorry, just saw this after merge...
In order to make the outcome of this method durable, it has to be in the
safe store for C*, so felt it was best to move it there as that's were we
mutate state normally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
