dcapwell commented on code in PR #46:
URL: https://github.com/apache/cassandra-accord/pull/46#discussion_r1204727069


##########
accord-core/src/main/java/accord/impl/InMemoryCommandStore.java:
##########
@@ -333,38 +344,6 @@ private void forEach(Routable keyOrRange, Ranges slice, 
Consumer<RoutableKey> fo
         }
     }
 
-    @Override
-    protected void registerHistoricalTransactions(Deps deps)

Review Comment:
   moved this to safe command store... we can't handle this in `CommandStore` 
for C* unless we lazy load the dependencies (which requires 
https://github.com/apache/cassandra-accord/pull/27)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to