dcapwell commented on code in PR #46:
URL: https://github.com/apache/cassandra-accord/pull/46#discussion_r1204730111


##########
accord-core/src/main/java/accord/topology/Topology.java:
##########
@@ -236,7 +236,9 @@ private Topology forSubset(int[] newSubset, Collection<Id> 
nodes)
         return new Topology(epoch, shards, ranges, nodeLookup, rangeSubset, 
newSubset);
     }
 
-    private <P1> int[] subsetFor(Unseekables<?, ?> select, 
IndexedPredicate<P1> predicate, P1 param)
+    private enum OnUnknown { REJECT, IGNORE }

Review Comment:
   in this case, `TokenKey` is scoped to the `keyspace`, so a new table in an 
existing keyspace is fine, but adding a new keyspace and touching it causes 
this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to