adelapena commented on code in PR #2310: URL: https://github.com/apache/cassandra/pull/2310#discussion_r1224138412
########## test/unit/org/apache/cassandra/cql3/validation/operations/CQLVectorTest.java: ########## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3.validation.operations; + +import org.junit.Test; + +import org.apache.cassandra.cql3.CQLTester; + +public class CQLVectorTest extends CQLTester.InMemory Review Comment: The problem with vector terminals doesn't need any new functions to reproduce. It also breaks existing functions like the venerable `token` function: ```java @Test public void token() { createTable(KEYSPACE, "CREATE TABLE %s (pk vector<int, 2> primary key)"); execute("INSERT INTO %s (pk) VALUES (?)", vector(1, 2)); long tokenColumn = execute("SELECT token(pk) as t FROM %s").one().getLong("t"); long tokenTerminal = execute("SELECT token([1, 2]) as t FROM %s").one().getLong("t"); // Type error Assert.assertEquals(tokenColumn, tokenTerminal); } ``` Also, users can try to use vectors on their UDFs, where they will hit the same problem: ```java @Test public void udf() throws Throwable { createTable(KEYSPACE, "CREATE TABLE %s (pk int primary key, value vector<int, 2>)"); String function = createFunction(KEYSPACE, "", "CREATE FUNCTION %s (x vector<int, 2>) " + "CALLED ON NULL INPUT " + "RETURNS vector<int, 2> " + "LANGUAGE java " + "AS 'return x;'"); Vector<Integer> value = vector(1, 2); execute("INSERT INTO %s (pk, value) VALUES (0, ?)", value); assertRows(execute("SELECT " + function + "(value) FROM %s WHERE pk=0"), row(value)); assertRows(execute("SELECT " + function + "([1, 2]) FROM %s WHERE pk=0"), row(value)); // Type error } ``` The later example hits another bug when creating the function, where it says that the argument and the return type cannot be frozen. It's caused [here](https://github.com/dcapwell/cassandra/blob/CASSANDRA-18504/src/java/org/apache/cassandra/cql3/statements/schema/CreateFunctionStatement.java#L99) and [here](https://github.com/dcapwell/cassandra/blob/CASSANDRA-18504/src/java/org/apache/cassandra/cql3/statements/schema/CreateFunctionStatement.java#L103). I think we only need to add there an exception for vectors, the same way we do for tuples. Changing that lets the test pass the function creation, just to crash on the `WithList` type error. Both examples for the token function and UDFs work if we use lists instead of vectors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
