dcapwell commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1223291891


##########
src/java/org/apache/cassandra/utils/vint/VIntCoding.java:
##########
@@ -134,6 +135,11 @@ public static int getVInt32(ByteBuffer input, int 
readerIndex)
         return checkedCast(decodeZigZag64(getUnsignedVInt(input, 
readerIndex)));
     }
 
+    public static long getVInt(ByteBuffer input, int readerIndex)

Review Comment:
   left a comment at the other one, I impl every version (added dead code) just 
to have them there... I needed one of the 4 cases so figured it would be best 
to have all 4 at once rather than leave to the next author



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to