JeetKunDoug commented on code in PR #48: URL: https://github.com/apache/cassandra-sidecar/pull/48#discussion_r1227328663
########## adapters/latest/src/main/java/org/apache/cassandra/sidecar/adapters/latest/CassandraClusterMembershipOperations.java: ########## @@ -16,17 +16,17 @@ * limitations under the License. */ -package org.apache.cassandra.sidecar.cassandra40; +package org.apache.cassandra.sidecar.adapters.trunk; Review Comment: See my previous comment about the "default" or "latest" implementation vs. forking a new implementation for some older version that doesn't support something. Calling this 40 doesn't make sense because it is, essentially, the _default_ implementation. Again, with 3.11 also in the codebase this would have been clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
