JeetKunDoug commented on code in PR #48:
URL: https://github.com/apache/cassandra-sidecar/pull/48#discussion_r1227329563
##########
src/test/integration/org/apache/cassandra/sidecar/routes/SnapshotsHandlerIntegrationTest.java:
##########
@@ -216,7 +220,7 @@ private String
createTestTableAndPopulate(CassandraTestContext cassandraTestCont
private void assertNotFoundOnDeleteSnapshot(VertxTestContext context,
String testRoute) throws InterruptedException
{
WebClient client = WebClient.create(vertx);
- client.delete(config.getPort(), "localhost", testRoute)
+ client.delete(config.getPort(), "127.0.0.1", testRoute)
Review Comment:
Depends on the context - in a multi-node in-jvm test module you need IP
addresses... in unit tests where we're mocking things it was set to `localhost`
and changing it broke stuff, so I reverted some of them back. The two sets
could likely be consolidated at some point but right now that's the split
required to get tests to pass in all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
