yifan-c commented on code in PR #48: URL: https://github.com/apache/cassandra-sidecar/pull/48#discussion_r1227352125
########## adapters/latest/src/main/java/org/apache/cassandra/sidecar/adapters/latest/CassandraAdapter.java: ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.adapters.trunk; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.datastax.driver.core.Metadata; +import com.datastax.driver.core.Row; +import com.datastax.driver.core.Session; +import org.apache.cassandra.sidecar.common.CQLSessionProvider; +import org.apache.cassandra.sidecar.common.ClusterMembershipOperations; +import org.apache.cassandra.sidecar.common.ICassandraAdapter; +import org.apache.cassandra.sidecar.common.JmxClient; +import org.apache.cassandra.sidecar.common.NodeSettings; +import org.apache.cassandra.sidecar.common.StorageOperations; +import org.apache.cassandra.sidecar.common.TableOperations; +import org.apache.cassandra.sidecar.common.dns.DnsResolver; +import org.jetbrains.annotations.Nullable; + +/** + * A {@link ICassandraAdapter} implementation for Cassandra 4.0 and later + */ +public class CassandraAdapter implements ICassandraAdapter Review Comment: There will be more version supported. The adapters should have the version in the name at the beginning, instead of a refactoring (guaranteed) in the future. The 3.11 example in fact supports that we should have version in the class name in the case of adapting to multiple versions, except Sidecar does not support 3.11 so we drop it. The concern in my original comment is not about conflicts. It is about clarity of the code, e.g. full qualified class name vs having version string in the simple class name, `org.apache.cassandra.sidecar.adapters.trunk.CassandraAdapter` vs. `Cassasndra50Adapter`. Btw, I think it is not a good idea to use `trunk`. It is the "pointer" that can change to other versions. Sidecar should use 50 for clarity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
