michaelsembwever commented on code in PR #2411:
URL: https://github.com/apache/cassandra/pull/2411#discussion_r1228135013
##########
.gitignore:
##########
@@ -69,6 +69,8 @@ target/
.DS_Store
Thumbs.db
.ccm/
+checkstyle_cachefile
+checkstyle_test_cachefile
Review Comment:
> Even I have not changed single line of the source code, I will need to do
checkstyle again?
You compile classes again, even if you haven't touched them. That's the
point with clean, and the behaviour i would expect.
I'm weary of having anything at the top level, it causes problems. Having
it under build/ (specifically `${build.dir}`) in in line with the work
happening in 18133.
I would also be in favour of not calling checkstyle when jar building. With
18133, all linters are a separate command (e.g. .build/check-code.sh). To me
this makes sense, has we also have owasp which is critical but we are ignoring
because it's too slow (and network prone).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
