Mmuzaf commented on code in PR #2411: URL: https://github.com/apache/cassandra/pull/2411#discussion_r1228195080
########## .gitignore: ########## @@ -69,6 +69,8 @@ target/ .DS_Store Thumbs.db .ccm/ +checkstyle_cachefile +checkstyle_test_cachefile Review Comment: My understanding is that the `ant realclean` must clean the checkstyle cache as well, this is something much closer to the way Maven behaves and much more expected than having a dedicated checkstyle cache somewhere else. I'm +1 here. I did small local tests by running `ant build` and changing some classes a few times sequentially, so that now it doesn't check the files that were not changed. Only the affected files are checked, which in turn speeds up the local build. ``` #1 /Users/x/IdeaProjects/cassandra/src/java/org/apache/cassandra/config/CassandraRelevantProperties.java=1686663255220 #2 /Users/x/IdeaProjects/cassandra/src/java/org/apache/cassandra/config/CassandraRelevantProperties.java=1686663333852 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
