Mmuzaf commented on code in PR #2411:
URL: https://github.com/apache/cassandra/pull/2411#discussion_r1228154156
##########
checkstyle.xml:
##########
@@ -23,6 +23,8 @@
<property name="severity" value="error"/>
<property name="fileExtensions" value="java, properties, xml"/>
+
+ <property name="cacheFile" value="${build.dir}/checkstyle_cachefile"/>
Review Comment:
I have checked locally and everything is working as expected using the
`cacheFile` property. I'm wondering if it's worth putting the cache file under
the `checkstyle' directory `${checkstyle.log.dir}` to keep everything in one
place?
I have checked it locally, but I'm not sure that the ant is resolving the
`${build.dir}` placeholder correctly.
##########
checkstyle.xml:
##########
@@ -23,6 +23,8 @@
<property name="severity" value="error"/>
<property name="fileExtensions" value="java, properties, xml"/>
+
+ <property name="cacheFile" value="${build.dir}/checkstyle_cachefile"/>
Review Comment:
I have checked locally and everything is working as expected using the
`cacheFile` property. I'm wondering if it's worth putting the cache file under
the `checkstyle' directory `${checkstyle.log.dir}` to keep everything in one
place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
