JeetKunDoug commented on code in PR #48:
URL: https://github.com/apache/cassandra-sidecar/pull/48#discussion_r1228863253
##########
src/test/java/org/apache/cassandra/sidecar/routes/sstableuploads/BaseUploadsHandlerTest.java:
##########
@@ -181,7 +181,7 @@ public CassandraAdapterDelegate delegate()
public Configuration abstractConfig(InstancesConfig instancesConfig)
{
when(mockConfiguration.getInstancesConfig()).thenReturn(instancesConfig);
- when(mockConfiguration.getHost()).thenReturn("127.0.0.1");
+ when(mockConfiguration.getHost()).thenReturn("localhost");
Review Comment:
Done
##########
src/test/java/org/apache/cassandra/sidecar/routes/SchemaHandlerTest.java:
##########
@@ -165,7 +165,7 @@ public class SchemaHandlerTestModule extends AbstractModule
public InstancesConfig instanceConfig() throws IOException
{
final int instanceId = 100;
- final String host = "127.0.0.1";
+ final String host = "localhost";
Review Comment:
Done
##########
src/test/java/org/apache/cassandra/sidecar/routes/GossipInfoHandlerTest.java:
##########
@@ -129,7 +129,7 @@ static class GossipInfoHandlerTestModule extends
AbstractModule
public InstancesConfig instanceConfig() throws IOException
{
final int instanceId = 100;
- final String host = "127.0.0.1";
+ final String host = "localhost";
Review Comment:
Done
##########
src/test/java/org/apache/cassandra/sidecar/routes/ExtractHostAddressWithoutPortTest.java:
##########
@@ -30,15 +30,15 @@
@Test
void testAddressWithIPv4Host()
{
- final String host =
AbstractHandler.extractHostAddressWithoutPort("127.0.0.1");
- assertEquals("127.0.0.1", host);
+ final String host =
AbstractHandler.extractHostAddressWithoutPort("localhost");
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
