JeetKunDoug commented on code in PR #48:
URL: https://github.com/apache/cassandra-sidecar/pull/48#discussion_r1228859565


##########
build.gradle:
##########
@@ -24,6 +24,8 @@ plugins {
     id 'com.google.cloud.tools.jib' version '2.2.0'
 }
 
+ext.dtestJar = System.getenv("DTEST_JAR") ?: "dtest-5.0.jar" // trunk is 
currently 5.0.jar - update when trunk moves

Review Comment:
   Also just note that the only reason this is included is to use for the dtest 
classes - we're not otherwise using the jar, so in theory we could just pick 
one, but I thought it would be good to use trunk so we would catch ABI changes 
in trunk more easily (and at one point 4.0 didn't even _work_ because it was 
missing some packages, but I've fixed that in the dtest jar build process now)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to