JeetKunDoug commented on code in PR #48:
URL: https://github.com/apache/cassandra-sidecar/pull/48#discussion_r1228858330
##########
adapters/latest/build.gradle:
##########
@@ -18,10 +19,11 @@ test {
}
dependencies {
- implementation(project(":common"))
+ api(project(":common"))
+ api("com.google.guava:guava:${project.rootProject.guavaVersion}")
compileOnly('org.jetbrains:annotations:23.0.0')
compileOnly('com.datastax.cassandra:cassandra-driver-core:3.11.3')
-
implementation("com.google.guava:guava:${project.rootProject.guavaVersion}")
+ implementation("org.apache.commons:commons-lang3:3.9")
Review Comment:
There were already a ton of usages of commons-lang3 in other subprojects so
I don't think it's a big deal - the other ones are actually depending on some
transitive dependency to pull it in it seems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
