ekaterinadimitrova2 commented on code in PR #2421:
URL: https://github.com/apache/cassandra/pull/2421#discussion_r1232772101
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -45,6 +45,11 @@ public TestNameCheckTask()
{
}
+ public static void main(String[] args)
+ {
+ new TestNameCheckTask().execute();
Review Comment:
This is incorrect, as we no longer fail the ant task.
It completes successfully if I test with an invalid test name; there is only
one exception in the logs, which people will miss
##########
src/java/org/apache/cassandra/utils/concurrent/Ref.java:
##########
@@ -91,7 +93,7 @@
* Once the Ref.GlobalState has been completely released, the Tidy method is
called and it removes the global reference
* to itself so it may also be collected.
*/
-public final class Ref<T> implements RefCounted<T>
+public class Ref<T> implements RefCounted<T>
Review Comment:
I am worried about having this public class not final; I think I mentioned
it already in one of the commits yesterday, but adding here for completeness.
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -45,6 +45,11 @@ public TestNameCheckTask()
{
}
+ public static void main(String[] args)
+ {
+ new TestNameCheckTask().execute();
Review Comment:
I did some testing, and the issue with the ant task is only with 11. So as a
workaround, we can make the task to run at the moment only with JDK11.
While it is good to run it with both JDKs, the output is the same with both
JDKs.
So I suggest we open a follow-up ticket and make it run only with JDK11 here
to unblock ourselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
