djatnieks commented on code in PR #2421: URL: https://github.com/apache/cassandra/pull/2421#discussion_r1235988404
########## src/java/org/apache/cassandra/utils/concurrent/Ref.java: ########## @@ -91,7 +93,7 @@ * Once the Ref.GlobalState has been completely released, the Tidy method is called and it removes the global reference * to itself so it may also be collected. */ -public final class Ref<T> implements RefCounted<T> +public class Ref<T> implements RefCounted<T> Review Comment: Okay, I could change `DirectBufferRef` to wrap a `Ref` instead of extending `Ref` - then `Ref` can remain `final`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
