djatnieks commented on code in PR #2421:
URL: https://github.com/apache/cassandra/pull/2421#discussion_r1236195001
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -45,6 +45,11 @@ public TestNameCheckTask()
{
}
+ public static void main(String[] args)
+ {
+ new TestNameCheckTask().execute();
Review Comment:
Thank you! I made a test class with an invalid name and see that while there
is an error logged, the build continues.
I think I found another option - adding `failonerror="yes"` to the java
task, like this:
```
<java taskname="check-test-names" fork="true" failonerror="yes"
classname="org.apache.cassandra.anttasks.TestNameCheckTask"
classpath="${test.classes}">
```
With this change, running `ant build-test` with an invalid test name both
logs an error and stops the build with an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
