pkolaczk commented on code in PR #2420:
URL: https://github.com/apache/cassandra/pull/2420#discussion_r1236667069
##########
src/java/org/apache/cassandra/io/sstable/SSTableZeroCopyWriter.java:
##########
@@ -61,12 +58,8 @@ public SSTableZeroCopyWriter(Builder<?, ?> builder,
lifecycleNewTracker.trackNew(this);
this.componentWriters = new HashMap<>();
- if
(!descriptor.getFormat().streamingComponents().containsAll(components))
- throw new AssertionError(format("Unsupported streaming component
detected %s",
-
Sets.difference(ImmutableSet.copyOf(components),
descriptor.getFormat().streamingComponents())));
-
Review Comment:
As for this:
```
public static final Component.Type SAI = Component.Type.create("SAI",
"SAI\\+.*.db", null);
```
This wouldn't be very consistent with what we use component types for now in
the core - because now each core sstable component has its own type. So why
should we throw all different SAI component types into a single type?
I think we need to take another look at how custom components are registered
and simply allow modules to provide their own types. So SAI component types
should be defined in SAI. We could also allow the component type to decide
whether it should be streamed or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
