maedhroz commented on code in PR #2420:
URL: https://github.com/apache/cassandra/pull/2420#discussion_r1240035239
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableFormat.java:
##########
@@ -59,7 +60,18 @@ public interface SSTableFormat<R extends SSTableReader, W
extends SSTableWriter>
*/
Set<Component> allComponents();
- Set<Component> streamingComponents();
+ /**
+ * Returns the components that should be streamed to other nodes on repair
/ rebuild.
+ * This includes only the core SSTable components produced by this format.
+ * Custom components registered by e.g. secondary indexes are not included.
+ * Use {@link SSTableReader#getStreamingComponents()} for the list of all
components including the custom ones.
+ */
+ default Set<Component> streamingComponents()
Review Comment:
Once all `Component` instances have their "streamability" embedded, we don't
need this method at all, right? i.e. `SSTableZeroCopyWriter` will no longer
need special casing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
