maedhroz commented on code in PR #2420:
URL: https://github.com/apache/cassandra/pull/2420#discussion_r1240043268
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableFormat.java:
##########
@@ -156,23 +168,23 @@ public static class Types
{
// the base data for an sstable: the remaining components can be
regenerated
// based on the data component
- public static final Component.Type DATA =
Component.Type.createSingleton("DATA", "Data.db", null);
+ public static final Component.Type DATA =
Component.Type.createSingleton("DATA", "Data.db", true, null);
// file to hold information about uncompressed data length, chunk
offsets etc.
- public static final Component.Type COMPRESSION_INFO =
Component.Type.createSingleton("COMPRESSION_INFO", "CompressionInfo.db", null);
+ public static final Component.Type COMPRESSION_INFO =
Component.Type.createSingleton("COMPRESSION_INFO", "CompressionInfo.db", true,
null);
// statistical metadata about the content of the sstable
- public static final Component.Type STATS =
Component.Type.createSingleton("STATS", "Statistics.db", null);
+ public static final Component.Type STATS =
Component.Type.createSingleton("STATS", "Statistics.db", true, null);
// serialized bloom filter for the row keys in the sstable
- public static final Component.Type FILTER =
Component.Type.createSingleton("FILTER", "Filter.db", null);
+ public static final Component.Type FILTER =
Component.Type.createSingleton("FILTER", "Filter.db", true, null);
// holds CRC32 checksum of the data file
- public static final Component.Type DIGEST =
Component.Type.createSingleton("DIGEST", "Digest.crc32", null);
+ public static final Component.Type DIGEST =
Component.Type.createSingleton("DIGEST", "Digest.crc32", true, null);
// holds the CRC32 for chunks in an uncompressed file.
- public static final Component.Type CRC =
Component.Type.createSingleton("CRC", "CRC.db", null);
+ public static final Component.Type CRC =
Component.Type.createSingleton("CRC", "CRC.db", true, null);
// table of contents, stores the list of all components for the
sstable
- public static final Component.Type TOC =
Component.Type.createSingleton("TOC", "TOC.txt", null);
+ public static final Component.Type TOC =
Component.Type.createSingleton("TOC", "TOC.txt", false, null);
// built-in secondary index (may exist multiple per sstable)
- public static final Component.Type SECONDARY_INDEX =
Component.Type.create("SECONDARY_INDEX", "SI_.*.db", null);
+ public static final Component.Type SECONDARY_INDEX =
Component.Type.create("SECONDARY_INDEX", "SI_.*.db", true, null);
Review Comment:
nit: Are `SECONDARY_INDEX` components streamable? I thought we always
rebuilt them at the receiver...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
