maedhroz commented on code in PR #2433:
URL: https://github.com/apache/cassandra/pull/2433#discussion_r1242440620
##########
test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java:
##########
@@ -70,6 +72,12 @@
public class SecondaryIndexTest extends CQLTester
{
public static final int TOO_BIG = 1024 * 65;
+
+ @BeforeClass
+ public static void setDefaultSecondaryIndex()
+ {
+ DatabaseDescriptor.setDefaultSecondaryIndex(CassandraIndex.NAME);
Review Comment:
There were two options to make sure this test works as intended independent
of what the YAML says. One is this, just making sure the legacy 2i is the
default, and none of the tests themselves need to change their index creation
DDL. The other would be changing all the index creation DDL. I chose the former
to keep the diff smaller.
`shouldCreateCassandraIndexExplicitly` though...that could change, or a new
test be added to check explicit legacy 2i creation when it isn't the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
