maedhroz commented on code in PR #2433:
URL: https://github.com/apache/cassandra/pull/2433#discussion_r1242456006
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java:
##########
@@ -94,6 +94,8 @@
public class StorageAttachedIndex implements Index
{
+ public static final String NAME = "sai";
Review Comment:
See https://github.com/apache/cassandra/pull/2433#discussion_r1242403756
> We could always build a service provider framework or something here to
register the index name aliases for custom 2i implementations and support them
in CREATE INDEX...but not in this patch.
The other complication here is that `CassandraIndex` is an abstract class.
It's subclasses were never meant to be exposed to the user, which makes the SPI
thing a little more sticky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
