michaelsembwever commented on code in PR #2434:
URL: https://github.com/apache/cassandra/pull/2434#discussion_r1260739865
##########
.build/build-owasp.xml:
##########
@@ -16,9 +16,11 @@
~ See the License for the specific language governing permissions and
~ limitations under the License.
-->
-<project basedir="." name="apache-cassandra-owasp-tasks">
+<project basedir="." name="apache-cassandra-owasp-tasks"
+ xmlns:if="ant:if"
+ xmlns:unless="ant:unless">
<property name="dependency-check.version" value="8.3.1"/>
- <property name="dependency-check.home"
value="${build.dir}/dependency-check-ant-${dependency-check.version}"/>
+ <property name="dependency-check.home"
value="${user.home}/.ant/dependency-check-ant-${dependency-check.version}"/>
Review Comment:
is it specific to `ant` ?
could it be under
`${user.home}/.owasp/dependency-check-ant-${dependency-check.version}` instead?
how big does it get? should it go under `${user.home}/.cache/owasp/…`
instead? (mine was ~500M , but it will grow over time…)
@smiklosovic thoughts?
##########
.build/build-owasp.xml:
##########
@@ -16,9 +16,11 @@
~ See the License for the specific language governing permissions and
~ limitations under the License.
-->
-<project basedir="." name="apache-cassandra-owasp-tasks">
+<project basedir="." name="apache-cassandra-owasp-tasks"
+ xmlns:if="ant:if"
+ xmlns:unless="ant:unless">
<property name="dependency-check.version" value="8.3.1"/>
- <property name="dependency-check.home"
value="${build.dir}/dependency-check-ant-${dependency-check.version}"/>
+ <property name="dependency-check.home"
value="${user.home}/.ant/dependency-check-ant-${dependency-check.version}"/>
Review Comment:
is it specific to `ant` ?
could it be under
`${user.home}/.owasp/dependency-check-ant-${dependency-check.version}` instead?
how big does it get? should it go under `${user.home}/.cache/owasp/…`
instead? (mine was ~500M , but it will grow over time…)
@smiklosovic thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
