smiklosovic commented on code in PR #2434:
URL: https://github.com/apache/cassandra/pull/2434#discussion_r1260835929


##########
.build/build-owasp.xml:
##########
@@ -83,4 +85,67 @@
             </fileset>
         </dependency-check>
     </target>
+
+    <target depends="init" name="license-report">
+        <exec executable="jq" osfamily="unix" dir="${basedir}" logError="true" 
failonerror="false" failifexecutionfails="false">

Review Comment:
   we might have a check for this in `build.xml` as we have for Ant.
   
       <fail message="You need to use Ant of version at least 1.10 to 
continue.">
         <condition>
           <not>
             <antversion atleast="1.10"/>
           </not>
         </condition>
       </fail>
   
   Even "antversion" is in-built target (I think so), something similar should 
be done for all other needed tooling and error out as soon as possible if it is 
not available so it will not fail unnecessarily somewhere down the road.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to