smiklosovic commented on code in PR #2434:
URL: https://github.com/apache/cassandra/pull/2434#discussion_r1260837920
##########
.build/build-owasp.xml:
##########
@@ -83,4 +85,67 @@
</fileset>
</dependency-check>
</target>
+
+ <target depends="init" name="license-report">
+ <exec executable="jq" osfamily="unix" dir="${basedir}" logError="true"
failonerror="false" failifexecutionfails="false">
Review Comment:
I see there is `failifexecutionfails="false", could you explain the
consequences? So we are OK when this fails? So if that command is not present,
we will just silently skip it? What are the consequences of that?
I think if it just prints some report from owasp, that might be acceptable
and we do not need to do anything after all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
