smiklosovic commented on code in PR #2490:
URL: https://github.com/apache/cassandra/pull/2490#discussion_r1266361028
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -79,6 +79,7 @@ public static Set<String> splitCommaDelimited(String src)
public String authenticator;
public String authorizer;
public String role_manager;
+ public String crypto_provider;
Review Comment:
The benefit is that it is configurable. Are you 100% sure that there will
never be a provider which is configurable? Your provider is not, are you sure
you can say it above any possible provider yet to be implemented?
Also, it is very easy to do that in terms of how it looks like in
cassandra.yaml. Instead of this
`crypto_provider: this.is.my.ClassImpl`
It would be like
crypto_provider:
- class_name: this.is.my.ClassImpl
I do not think it is a lot to ask given the fact the we open ourselves to a
lot of possibilities when it is potentially configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
