smiklosovic commented on code in PR #2490:
URL: https://github.com/apache/cassandra/pull/2490#discussion_r1266369041
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1217,6 +1221,25 @@ public static void applySslContext()
}
}
+ public static void applyCryptoProvider()
+ {
+ try
+ {
+ if (conf.crypto_provider == null)
+ conf.crypto_provider = new
ParameterizedClass("org.apache.cassandra.security.DefaultCryptoProvider", null);
+
+ Class<?> cryptoProviderClass =
Class.forName(conf.crypto_provider.class_name);
Review Comment:
@ayushisingh29 what if `class_name` is null? Can't you have
`conf.crypto_provider` non-null but `class_name` would be null? What happens if
you have this in yaml?
crypto_provider:
- parameters:
- a: "b"
I would check if `class_name` is null and if it is we either error out or we
set it to default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
