smiklosovic commented on code in PR #2490:
URL: https://github.com/apache/cassandra/pull/2490#discussion_r1266366416
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1217,6 +1221,25 @@ public static void applySslContext()
}
}
+ public static void applyCryptoProvider()
+ {
+ try
+ {
+ if (conf.crypto_provider == null)
+ conf.crypto_provider = new
ParameterizedClass("org.apache.cassandra.security.DefaultCryptoProvider", null);
Review Comment:
@ayushisingh29 would it be possible to use
'DefaultCryptoProvider.class.getName()' instead of putting there just string?
What if the name of that provider changes or the package it is located in
changes? Then you would need to fix it here as well ... Using class.getName(),
you have it for free.
Does it interfere with DatabaseDescriptorRefTest or something similar that
it can not be used like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
