maedhroz commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1267385265
##########
src/java/org/apache/cassandra/index/SecondaryIndexManager.java:
##########
@@ -1706,6 +1754,7 @@ public void handleNotification(INotification
notification, Object sender)
indexes.values()
.stream()
.filter(Index::shouldBuildBlocking)
+ .filter(i ->
!i.isSSTableAttached())
Review Comment:
Yeah...I think for the time being, I'm going to just have `SASIIndex` return
false from `isSSTableAttached()` (the default). There's no point in changing it
and worrying about whether SASI works the same way for `SSTableImporter` w/
more tests, etc.
By the way, `SSTableFlushObserver` also ensures that SAI indexes build when
they should for the SSTable scrubber, upgrader, and splitter tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
