adelapena commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1266721661
##########
src/java/org/apache/cassandra/index/SecondaryIndexManager.java:
##########
@@ -491,9 +497,108 @@ public static String getIndexName(String cfName)
return StringUtils.substringAfter(cfName,
Directories.SECONDARY_INDEX_NAME_SEPARATOR);
}
+ // TODO: JavaDoc if this approach survives...mention that this should not
be used for live SSTables
+ public boolean validateStorageAttachedIndexes(Collection<SSTableReader>
sstables, boolean failIncomplete) throws IOException
+ {
+ // TODO: A more generic approach via the Index interface rather than
just working w/ SAI
+ Set<StorageAttachedIndex> toValidate =
indexes.values().stream().filter(i -> i instanceof StorageAttachedIndex)
+ .map(i
-> (StorageAttachedIndex) i)
+
.collect(Collectors.toSet());
+
+ if (toValidate.isEmpty())
+ return true;
+
+ boolean complete = true;
+
+ for (SSTableReader sstable : sstables)
+ {
+ IndexDescriptor indexDescriptor = IndexDescriptor.create(sstable);
+
+ if (indexDescriptor.isPerSSTableIndexBuildComplete())
+ {
+ indexDescriptor.checksumPerSSTableComponents();
+
+ for (StorageAttachedIndex index : toValidate)
+ {
+ if
(indexDescriptor.isPerColumnIndexBuildComplete(index.getIndexContext()))
+ {
+
indexDescriptor.checksumPerIndexComponents(index.getIndexContext());
+ }
+ else if (failIncomplete)
+ {
+ throw new
IllegalStateException(indexDescriptor.logMessage("Incomplete per-column index
build"));
+ }
+ else
+ {
+ complete = false;
+ }
+ }
+ }
+ else if (failIncomplete)
+ {
+ throw new
IllegalStateException(indexDescriptor.logMessage("Incomplete per-SSTable index
build"));
+ }
+ else
+ {
+ complete = false;
+ }
+ }
+
+ return complete;
+ }
+
+ // TODO: JavaDoc if this approach survives...
+ public void buildIndexesBlockingIncremental(Collection<SSTableReader>
sstables)
+ {
+ Set<Index> toBuild =
indexes.values().stream().filter(Index::isSSTableAttached).collect(Collectors.toSet());
+
+ if (toBuild.isEmpty())
+ return;
+
+ logger.info("Submitting incremental index build of {} for data in {}",
+ commaSeparated(toBuild),
+
sstables.stream().map(SSTableReader::toString).collect(Collectors.joining(",")));
+
+ // Group all building tasks
+ Map<Index.IndexBuildingSupport, Set<Index>> byType = new HashMap<>();
+ for (Index index : toBuild)
+ {
+ Set<Index> stored =
byType.computeIfAbsent(index.getBuildTaskSupport(), i -> new HashSet<>());
+ stored.add(index);
+ }
+
+ // Schedule all index building tasks with callbacks to handle success
and failure
+ List<Future<?>> futures = new ArrayList<>(byType.size());
+ byType.forEach((buildingSupport, groupedIndexes) ->
+ {
+ SecondaryIndexBuilder builder =
buildingSupport.getIndexBuildTask(baseCfs, groupedIndexes, sstables, false);
+ AsyncPromise<Object> build = new AsyncPromise<>();
+
CompactionManager.instance.submitIndexBuild(builder).addCallback(new
FutureCallback<Object>()
+ {
+ @Override
+ public void onFailure(Throwable t)
+ {
+ logger.warn("Failed to build indexes {}",
getIndexNames(groupedIndexes));
Review Comment:
```suggestion
logger.warn("Failed to incrementally build indexes {}",
getIndexNames(groupedIndexes));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
