adelapena commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1266713100
##########
src/java/org/apache/cassandra/index/SecondaryIndexManager.java:
##########
@@ -491,9 +497,83 @@ public static String getIndexName(String cfName)
return StringUtils.substringAfter(cfName,
Directories.SECONDARY_INDEX_NAME_SEPARATOR);
}
+ // TODO: JavaDoc if this approach survives...mention that this should not
be used for live SSTables
+ public void validateStorageAttachedIndexes(Collection<SSTableReader>
sstables) throws IOException
+ {
+ // TODO: A more generic approach via the Index interface rather than
just working w/ SAI
Review Comment:
Probably SIM should call a validation method in each `Group`, and the
`Group` would call another validation method on each of its indexes. That way
the method on SIM doesn't need to know anything about `StorageAttachedIndex`,
and can have a more generic name such as `validateStreamedIndexes` or something
like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
