smiklosovic commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1270929265
##########
.build/build-resolver.xml:
##########
@@ -246,6 +247,15 @@
<file
file="${local.repository}/org/apache/cassandra/deps/sigar-bin/libsigar-x86-linux.so"/>
<file
file="${local.repository}/org/apache/cassandra/deps/sigar-bin/libsigar-x86-solaris.so"/>
</copy>
+
+ <copy todir="${build.lib}/corretto" quiet="true">
+ <file
file="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"/>
Review Comment:
@xgerman There is a lot of instances of this happening in that file, if you
look closed. If we fixed it just here, it would be inconsistent with everything
else. I would rather dedicated a separate ticket for cleaning it all up in one
shot. How does that sound to you?
##########
.build/build-resolver.xml:
##########
@@ -246,6 +247,15 @@
<file
file="${local.repository}/org/apache/cassandra/deps/sigar-bin/libsigar-x86-linux.so"/>
<file
file="${local.repository}/org/apache/cassandra/deps/sigar-bin/libsigar-x86-solaris.so"/>
</copy>
+
+ <copy todir="${build.lib}/corretto" quiet="true">
+ <file
file="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"/>
Review Comment:
@xgerman There is a lot of instances of this happening in that file, if you
look closer. If we fixed it just here, it would be inconsistent with everything
else. I would rather dedicated a separate ticket for cleaning it all up in one
shot. How does that sound to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
