michaelsembwever commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1271271862
##########
bin/cassandra.in.sh:
##########
@@ -86,9 +86,9 @@
JAVA_OPTS="$JAVA_OPTS:-Djava.library.path=$CASSANDRA_HOME/lib/sigar-bin"
operating_system=$(uname -s | tr '[:upper:]' '[:lower:]')
corretto_lib_pattern="AmazonCorrettoCryptoProvider-*-$operating_system-$(uname
-m).jar"
-corretto_lib="$(find "${CASSANDRA_HOME}"/lib/corretto -type f -name
"$corretto_lib_pattern" -exec basename {} \; | head -n 1)"
-if [ -f "${CASSANDRA_HOME}/lib/corretto/${corretto_lib}" ]; then
- CLASSPATH="$CLASSPATH${CASSANDRA_HOME}/lib/corretto/$corretto_lib";
+corretto_lib="$(find "${CASSANDRA_HOME}"/lib/platform -type f -name
"$corretto_lib_pattern" -exec basename {} \; | head -n 1)"
Review Comment:
a cleaner approach here without corretto specifics here and
`corretto_lib_pattern`
would be
```
if [ -d "${CASSANDRA_HOME}/lib/${operating_system}" ]; then
for jar in ${CASSANDRA_HOME}/lib/${operating_system}/*.jar ; then
CLASSPATH="$CLASSPATH:${jar}"
done
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
