michaelsembwever commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1271270432
##########
.build/build-resolver.xml:
##########
@@ -290,13 +290,12 @@
<url
url="${lib.download.base.url}/lib/sigar-bin/libsigar-x86-solaris.so"/>
</get>
- <!-- Amazon Corretto Crypto Providers for various architectures -->
- <resolve>
- <dependencies>
- <dependency groupId="software.amazon.cryptools"
artifactId="AmazonCorrettoCryptoProvider" version="2.2.0"
classifier="linux-x86_64" />
- <dependency groupId="software.amazon.cryptools"
artifactId="AmazonCorrettoCryptoProvider" version="2.2.0"
classifier="linux-aarch_64" />
- </dependencies>
- </resolve>
+ <get
src="${artifact.github.release}/corretto/amazon-corretto-crypto-provider/releases/download/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"
+
dest="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"
+ usetimestamp="true" quiet="true" skipexisting="true"/>
+ <get
src="${artifact.github.release}/corretto/amazon-corretto-crypto-provider/releases/download/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-aarch_64.jar"
+
dest="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-aarch_64.jar"
+ usetimestamp="true" quiet="true" skipexisting="true"/>
Review Comment:
why was this re-introduced?
i'm also confused as to why the macro needed to be moved out…
`resolver-init` defines a number of macros that are used in other places…
##########
.build/build-resolver.xml:
##########
@@ -290,13 +290,12 @@
<url
url="${lib.download.base.url}/lib/sigar-bin/libsigar-x86-solaris.so"/>
</get>
- <!-- Amazon Corretto Crypto Providers for various architectures -->
- <resolve>
- <dependencies>
- <dependency groupId="software.amazon.cryptools"
artifactId="AmazonCorrettoCryptoProvider" version="2.2.0"
classifier="linux-x86_64" />
- <dependency groupId="software.amazon.cryptools"
artifactId="AmazonCorrettoCryptoProvider" version="2.2.0"
classifier="linux-aarch_64" />
- </dependencies>
- </resolve>
+ <get
src="${artifact.github.release}/corretto/amazon-corretto-crypto-provider/releases/download/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"
+
dest="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-x86_64.jar"
+ usetimestamp="true" quiet="true" skipexisting="true"/>
+ <get
src="${artifact.github.release}/corretto/amazon-corretto-crypto-provider/releases/download/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-aarch_64.jar"
+
dest="${local.repository}/software/amazon/cryptools/AmazonCorrettoCryptoProvider/2.2.0/AmazonCorrettoCryptoProvider-2.2.0-linux-aarch_64.jar"
+ usetimestamp="true" quiet="true" skipexisting="true"/>
Review Comment:
why was this re-introduced?
i'm also confused as to why the macro needed to be moved out…
`resolver-init` defines a number of macros that are used in other places…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
