Mmuzaf commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1272428184
##########
.build/parent-pom-template.xml:
##########
@@ -233,12 +233,52 @@
<id>zznate</id>
<name>Nate McCall</name>
</developer>
+ <developer>
+ <id>smiklosovic</id>
+ <name>Stefan Miklosovic</name>
+ </developer>
</developers>
<scm>
<connection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</connection>
<developerConnection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</developerConnection>
<url>https://gitbox.apache.org/repos/asf?p=cassandra.git;a=tree</url>
</scm>
+
+ <profiles>
+ <profile>
+ <id>x86_64</id>
+ <activation>
+ <os>
+ <arch>!aarch64</arch>
Review Comment:
Should we also add `<family>unix</family>`? This will look more correct even
if we never run on other operating systems.
Is the condition correct? Should we place here `x86_64` to avoid matching
other types of `x86`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
